Skip to content

chore: create bug report form #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 22, 2021
Merged

chore: create bug report form #428

merged 14 commits into from
Jul 22, 2021

Conversation

HonkingGoose
Copy link
Contributor

@HonkingGoose HonkingGoose commented Jul 21, 2021 •
edited
Loading

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list.
  • If some rule meta info is changed, I've regenerated the plugin shared configs.

Changes

  • Create bug report form

Context

Work in progress.

Go to https://github.com/HonkingGoose/eslint-plugin-testing-library/blob/patch-2/.github/ISSUE_TEMPLATE/bug_report.yml to see a rendered preview of the bug report form.

Helps with issue #400, but doesn't close it as we want forms for other things as well. 😉

  • Ideally we would have other issue forms to propose a new rule, to request a rule change, or to request a general change.

GItHub docs for the Issue Form:

@HonkingGoose
Copy link
Contributor Author

HonkingGoose commented Jul 21, 2021 •
edited
Loading

I'm ready for a round of review on this draft. Let me know what you think of it.

I need help with some placeholder text, so if you can suggest a better text, please do so. 😉

EDIT: Improved placeholder text myself.

HonkingGoose
HonkingGoose commented Jul 22, 2021
View reviewed changes
@HonkingGoose HonkingGoose marked this pull request as ready for review July 22, 2021 07:59
MichaelDeBoey
MichaelDeBoey requested changes Jul 22, 2021
View reviewed changes
HonkingGoose and others added 2 commits July 22, 2021 10:47
@HonkingGoose @MichaelDeBoey
Fix typo in label name
9c1a0f3 
Co-authored-by: Michaël De Boey <[email protected]>
@HonkingGoose @MichaelDeBoey
Make anything else field optional
54497b9 
Co-authored-by: Michaël De Boey <[email protected]>
Belco90
Belco90 approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a really good issue form! I think we got everything covered. Thanks again!

@Belco90 Belco90 merged commit 3db5f01 into testing-library:main Jul 22, 2021
@HonkingGoose HonkingGoose deleted the patch-2 branch July 22, 2021 09:31
@HonkingGoose
Copy link
Contributor Author

Hooray! Thank you for reviewing and merging my work. 😄

@github-actions
Copy link

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HonkingGoose @Belco90 @MichaelDeBoey